fix: avoid configuring root logger in mcpserver#2530
Open
HenryLee789 wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
fix: avoid configuring root logger in mcpserver#2530HenryLee789 wants to merge 1 commit intomodelcontextprotocol:mainfrom
HenryLee789 wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
configure_logging()from callinglogging.basicConfig()on the root loggermcplogger namespace, leaving third-party libraries such ashttpxoutside FastMCP's INFO/RichHandler setupcaplog, and user logging integrations still observe MCP warnings/errorsFixes #2527.
Testing
uv run pytest tests/server/mcpserver/test_logging.py -quv run pytest tests/server/mcpserver -quv run --frozen ruff format --check src/mcp/server/mcpserver/utilities/logging.py tests/server/mcpserver/test_logging.pyuv run --frozen ruff check src/mcp/server/mcpserver/utilities/logging.py tests/server/mcpserver/test_logging.pyuv run --frozen pyright src/mcp/server/mcpserver/utilities/logging.py tests/server/mcpserver/test_logging.pyuv run --frozen --no-sync coverage report --include='src/mcp/server/mcpserver/utilities/logging.py'uv run --frozen --no-sync strict-no-covergit diff --check